Changes between Initial Version and Version 1 of Ticket #227
- Timestamp:
- 10/28/08 02:24:26 (16 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #227
- Property Resolution → Fixed
- Property Status new → closed
- Property Summary INLET_TEST failure due to src ticket 214 → INLET_TEST failure due to src:ticket:214
-
Ticket #227 – Description
initial v1 1 Src ticket #214 included:1 src:ticket:214 included: 2 2 3 "Also the code to set the xxxx_FSOBCmacros has been changed, eg this4 3 "Also the code to set the '''xxxx_FSOBC''' macros has been changed, eg this 4 {{{ 5 5 #if (defined WEST_FSRADIATION && defined WEST_FSNUDGING) || \ 6 6 defined WEST_M2FLATHER || defined WEST_FSCLAMPED || \ … … 8 8 # define WEST_FSOBC 9 9 #endif 10 }}} 10 11 has been changed to 11 12 {{{ 12 13 #if (defined WEST_FSRADIATION && defined WEST_FSNUDGING) || \ 13 14 defined WEST_M2FLATHER || defined WEST_FSCLAMPED 14 15 # define WEST_FSOBC 15 16 #endif 16 The use of xxxx_M2REDUCED does not by itself mean that boundary surface-height data is required. For example it is possible to use xxxx_M2REDUCED with xxxx_FSCHAPMAN, in which case there is no need for xxxx_FSOBC. " 17 }}} 18 The use of '''xxxx_M2REDUCED''' does not by itself mean that boundary surface-height data is required. For example it is possible to use''' xxxx_M2REDUCED''' with '''xxxx_FSCHAPMAN''', in which case there is no need for '''xxxx_FSOBC'''. " 17 19 18 20 ******************** 19 21 20 Well WHAT ABOUT THE POSSIBILITY THAT IT DID REQUIRE THE NEED FOR xxxx_FSOBC????? 21 The INLET_TEST uses : 22 Well WHAT ABOUT THE POSSIBILITY THAT IT DID REQUIRE THE NEED FOR '''xxxx_FSOBC'''????? 23 24 The '''INLET_TEST''' uses : 25 26 {{{ 22 27 #define FSOBC_REDUCED 23 28 #define NORTH_FSGRADIENT 24 29 #define NORTH_M2REDUCED 30 }}} 25 31 26 The src 214 change now removes the activation of the OBC flag, so the code never calls ana_fsobcand the tide is not added to the application!32 The src:ticket:214 change now removes the activation of the OBC flag, so the code never calls '''ana_fsobc''' and the tide is not added to the application! 27 33 28 Please modify the globaldefs.h file so that we CAN have xxxx_M2REDUCED and xxxx_FSOBC. This would be something like: 34 Please modify the '''globaldefs.h''' file so that we CAN have '''xxxx_M2REDUCED''' and '''xxxx_FSOBC'''. This would be something like: 35 36 {{{ 29 37 #if (defined WEST_FSRADIATION && defined WEST_FSNUDGING) || \ 30 defined WEST_M2FLATHER || defined WEST_FSCLAMPED|| \31 (defined WEST_M2REDUCED && defined FSOBC_REDUCED)38 (defined WEST_M2REDUCED && defined FSOBC_REDUCED) || \ 39 defined WEST_M2FLATHER || defined WEST_FSCLAMPED 32 40 # define WEST_FSOBC 33 41 #endif 42 }}} 34 43 (same for N,S, and E). 35 44