Opened 16 years ago
Closed 16 years ago
#227 closed bug (Fixed)
INLET_TEST failure due to src:ticket:214 — at Version 1
Reported by: | jcwarner | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Release ROMS/TOMS 3.2 |
Component: | Nonlinear | Version: | 3.2 |
Keywords: | Cc: |
Description (last modified by )
src:ticket:214 included:
"Also the code to set the xxxx_FSOBC macros has been changed, eg this
#if (defined WEST_FSRADIATION && defined WEST_FSNUDGING) || \ defined WEST_M2FLATHER || defined WEST_FSCLAMPED || \ defined WEST_M2REDUCED # define WEST_FSOBC #endif
has been changed to
#if (defined WEST_FSRADIATION && defined WEST_FSNUDGING) || \ defined WEST_M2FLATHER || defined WEST_FSCLAMPED # define WEST_FSOBC #endif
The use of xxxx_M2REDUCED does not by itself mean that boundary surface-height data is required. For example it is possible to use xxxx_M2REDUCED with xxxx_FSCHAPMAN, in which case there is no need for xxxx_FSOBC. "
Well WHAT ABOUT THE POSSIBILITY THAT IT DID REQUIRE THE NEED FOR xxxx_FSOBC?????
The INLET_TEST uses :
#define FSOBC_REDUCED #define NORTH_FSGRADIENT #define NORTH_M2REDUCED
The src:ticket:214 change now removes the activation of the OBC flag, so the code never calls ana_fsobc and the tide is not added to the application!
Please modify the globaldefs.h file so that we CAN have xxxx_M2REDUCED and xxxx_FSOBC. This would be something like:
#if (defined WEST_FSRADIATION && defined WEST_FSNUDGING) || \ (defined WEST_M2REDUCED && defined FSOBC_REDUCED) || \ defined WEST_M2FLATHER || defined WEST_FSCLAMPED # define WEST_FSOBC #endif
(same for N,S, and E).
Change History (1)
comment:1 by , 16 years ago
Description: | modified (diff) |
---|---|
Resolution: | → Fixed |
Status: | new → closed |
Summary: | INLET_TEST failure due to src ticket 214 → INLET_TEST failure due to src:ticket:214 |
Yes, thank you. I screw up and I missed that possible combination of CPP options.