INLET_TEST failure due to src:ticket:214

[jcwarner]

​src:ticket:214 included:

"Also the code to set the xxxx_FSOBC macros has been changed, eg this

#if (defined WEST_FSRADIATION  && defined WEST_FSNUDGING)  || \
     defined WEST_M2FLATHER    || defined WEST_FSCLAMPED   || \
     defined WEST_M2REDUCED
# define WEST_FSOBC
#endif

has been changed to

#if (defined WEST_FSRADIATION  && defined WEST_FSNUDGING)  || \
     defined WEST_M2FLATHER    || defined WEST_FSCLAMPED
# define WEST_FSOBC
#endif

The use of xxxx_M2REDUCED does not by itself mean that boundary surface-height data is required. For example it is possible to use xxxx_M2REDUCED with xxxx_FSCHAPMAN, in which case there is no need for xxxx_FSOBC. "

Well WHAT ABOUT THE POSSIBILITY THAT IT DID REQUIRE THE NEED FOR xxxx_FSOBC?????

The INLET_TEST uses :

#define FSOBC_REDUCED
#define NORTH_FSGRADIENT
#define NORTH_M2REDUCED

The ​src:ticket:214 change now removes the activation of the OBC flag, so the code never calls ana_fsobc and the tide is not added to the application!

Please modify the globaldefs.h file so that we CAN have xxxx_M2REDUCED and xxxx_FSOBC. This would be something like:

#if (defined WEST_FSRADIATION  && defined WEST_FSNUDGING)  || \
    (defined WEST_M2REDUCED    && defined FSOBC_REDUCED)   || \
     defined WEST_M2FLATHER    || defined WEST_FSCLAMPED
# define WEST_FSOBC
#endif

(same for N,S, and E).

[arango]

Yes, thank you. I screw up and I missed that possible combination of CPP options.