Opened 20 months ago

Closed 20 months ago

Last modified 19 months ago

#926 closed bug (Fixed)

IMPORTANT: Corrected couple of bugs

Reported by: arango Owned by:
Priority: major Milestone: Release ROMS/TOMS 4.1
Component: Nonlinear Version: 4.0
Keywords: Cc:

Description

  • mod_ncparam.F: Added missing END SELECT to the metadata for the adjoint sensitivity of inert tracers. Many thanks to Brian Powell for bringing this issue to my attention.
  • main2d.F: Moved the updating of time index iic(ng) to be bottom of the time stepping:
    !
    !-----------------------------------------------------------------------
    !  Advance time index and time clock.
    !-----------------------------------------------------------------------
    !
                DO ig=1,GridsInLayer(nl)
                  ng=GridNumber(ig,nl)
                  iic(ng)=iic(ng)+1
                  time(ng)=time(ng)+dt(ng)
                  step_counter(ng)=step_counter(ng)-1
                  CALL time_string (time(ng), time_code(ng))
                END DO
    
              END DO STEP_LOOP
    
    I corrected this bug some time ago in my research code, but I forgot to fix the distributed code. Anyway, many thanks to Bradley Reed for reporting this issue.

Change History (2)

comment:1 by arango, 20 months ago

Resolution: Fixed
Status: newclosed

comment:2 by arango, 19 months ago

The change to mod_ncparam.F was done incorrectly. Many thanks to Brian Powell for bringing this to my attention.

Note: See TracTickets for help on using tickets.