IMPORTANT: Compiling ROMS with CMake without ecbuild

[arango]

• Updated the compiling of ROMS with CMake without the need to use the ecbuild wrapper. The cbuild_roms.csh and cbuild_roms.sh include an option to use the ecbuild wrapper or not.

For example, in cbuild_roms.sh we have the USE_ECBUILD environmental flag to activate the ecbuild wrapper.

#export       USE_ECBUILD=on               # use "ecbuild" wrapper

• Removed several macros from the cbuild_roms scripts used to compile 4D-Var, biology, and sediment applications. Such switches are activated internally with CMake by using the application CPP-options.

Many thanks to David Robertson for improving the CMake compiling capabilities. They are fully functional.

---

• Corrected issues with the bottom fluxes for passive tracers. The assignment to btflx was missing in set_vbc.F:

#  if defined BIOLOGY || defined SEDIMENT || defined T_PASSIVE
!
!-----------------------------------------------------------------------
!  Load surface and bottom passive tracer fluxes (T m/s).
!-----------------------------------------------------------------------
!
      DO itrc=NAT+1,NT(ng)
        DO j=JstrR,JendR
          DO i=IstrR,IendR
            stflx(i,j,itrc)=stflux(i,j,itrc)
            btflx(i,j,itrc)=btflux(i,j,itrc)
          END DO
        END DO
      END DO
#  endif

We didn't noticed before because such fluxes are usually zero. Many thanks to Ashley Brereton for bringing this ​issue to my attention.

• Corrected a typo in def_info.F when defining the bry_file_ global attribute and a typo in checkdefs.F when reporting the BOUNDARY_ALLGATHER option. Many thanks to Jiangtao Xu for reporting these typos.