IMPORTANT: Updated ROMS test repository

[arango]

• The test repository was updated to include all the changes due to the tracer advection scheme ​src:ticket:839 that it now specified in ROMS standard input (roms.in) file. All the tracer advection CPP options were removed from the header file (application.h). However, the obsolete CPP options are still available in the build scripts so that one may run an older version of ROMS. For example, in build_roms.sh for the upwelling test case, we have:

  # The tracer advection is specified in the standard input file, but the
  # CPP options can be specified here for older versions for backward
  # compatibility.
  
  #setenv MY_CPP_FLAGS "${MY_CPP_FLAGS} -DTS_U3HADVECTION -DTS_C4VADVECTION"
  #setenv MY_CPP_FLAGS "${MY_CPP_FLAGS} -DTS_MPDATA"
  

• Corrected edit_multifile.F for the case FWD2HIS when using a single-file trajectory for the W4D-PSAS forecast sensitivity driver:

  !
  !  Save FWD information into the HIS structure so it can be used to
  !  process the NLM background trajectory by the ADM and TLM kernels.
  !  If multi-file, FWD(ng)%head and FWD(ng)%base is overwritten to
  !  default values. The initialized values in "load_s1d" are incorrect
  !  because the specified input filenames are already split.
  !
            CASE ('FWD2HIS')
              Nfiles=FWD(ng)%Nfiles
              IF (Nfiles.gt.1) THEN
                ...
              ELSE
                HIS(ng)%ncid=FWD(ng)%ncid
                HIS(ng)%files(1)=TRIM(FWD(ng)%files(1))
                HIS(ng)%name=TRIM(HIS(ng)%files(1))
                Istring=INDEX(HIS(ng)%name,'_outer',BACK=.FALSE.)
                IF (Istring.gt.0) THEN     ! outer loop prefix
                  lstr=Istring-1
                  HIS(ng)%head=TRIM(ADJUSTL(HIS(ng)%name(1:lstr)))
                  HIS(ng)%base=TRIM(ADJUSTL(HIS(ng)%name(1:lstr)))
                END IF
              END IF
  

  Many thanks to Andy More Patrick Drake for bringing this issue to my attention.

• Removed NL_BULK_FLUXES conditional during the initialization of the BLK structure in read_phypar.F. We have instead:

  #ifdef BULK_FLUXES
  !
  !  Allocate and initialize BLK I/O structure with the same values as
  !  HIS.
  !
        DO ng=1,Ngrids
          OutFiles=HIS(ng)%Nfiles
          allocate ( BLK(ng)%Nrec(OutFiles) )
          allocate ( BLK(ng)%time_min(OutFiles) )
          allocate ( BLK(ng)%time_max(OutFiles) )
          allocate ( BLK(ng)%Vid(NV) )
          allocate ( BLK(ng)%Tid(MT) )
          allocate ( BLK(ng)%files(OutFiles) )
          BLK(ng)%Nfiles=OutFiles
          BLK(ng)%Fcount=1
          BLK(ng)%Rindex=0
          BLK(ng)%ncid=-1
          BLK(ng)%Vid(1:NV)=-1
          BLK(ng)%Tid(1:MT)=-1
          BLK(ng)%Nrec=0
          BLK(ng)%time_min=0.0_dp
          BLK(ng)%time_max=0.0_dp
          BLK(ng)%label='BLK - nonlinear model bulk fluxes'
        END DO
  #endif