Opened 8 years ago
Closed 8 years ago
#705 closed bug (Fixed)
DIAGNOSTICS_BIO vs. WET_DRY
| Reported by: | kate | Owned by: | arango |
|---|---|---|---|
| Priority: | major | Milestone: | Release ROMS/TOMS 3.7 |
| Component: | Nonlinear | Version: | 3.7 |
| Keywords: | Cc: |
Description (last modified by )
I believe set_diags.F needs work when DIAGNOSTICS_BIO and WET_DRY are defined, but neither of the other DIAGNOSTICS_TS or DIAGNOSTICS_UV flags are defined.
The rmask_dia and friends are used without being set, causing odd numbers in the output. I'll take a stab at fixing it and let you know in the morning if it worked.
Attachments (1)
Change History (3)
by , 8 years ago
| Attachment: | set_diags.diff added |
|---|
comment:1 by , 8 years ago
The patch file seems to have helped. Now to go through and fix up the cobalt diagnostics so that rmask_full is used everywhere.
comment:2 by , 8 years ago
| Description: | modified (diff) |
|---|---|
| Resolution: | → Fixed |
| Status: | new → closed |
Yes, good catch. The diagnostics time-averaged masks (pmask_dia, rmask_dia, umask_dia, vmask_dia) were not computed since they were inside of the following directive:
# if defined DIAGNOSTICS_TS || defined DIAGNOSTICS_UV ... # endif
Note:
See TracTickets
for help on using tickets.
patch file for set_diags.F