Opened 10 years ago
Closed 10 years ago
#676 closed bug (Fixed)
IMPORTANT: deallocation in nesting.F
| Reported by: | arango | Owned by: | arango |
|---|---|---|---|
| Priority: | major | Milestone: | Release ROMS/TOMS 3.7 |
| Component: | Nonlinear | Version: | 3.7 |
| Keywords: | Cc: |
Description
There are couple of typos in nesting.F when deallocating Fmsk in fine2coarse2d and fine2coarse3d. We have:
# ifdef MASKING
IF (allocated(F)) THEN
deallocate (Fmsk)
END IF
# endif
instead of
# ifdef MASKING
IF (allocated(Fmsk)) THEN
deallocate (Fmsk)
END IF
# endif
This results in a memory leak in nesting applications with more than one refinement grid. It also depend on how compilers deal with local allocatable variables and their pointers. This may affect the land/sea masking when averaging fine grid solution into coarse grid.
Please update! Many thanks to John Warner for bringing to my attention.
Note:
See TracTickets
for help on using tickets.
