#665 closed bug (Fixed)
Improvements to fennel.h — at Version 1
| Reported by: | m.hadfield | Owned by: | arango |
|---|---|---|---|
| Priority: | major | Milestone: | Release ROMS/TOMS 3.7 |
| Component: | Nonlinear | Version: | 3.7 |
| Keywords: | Cc: |
Description (last modified by )
Attached is a lightly modified version of fennel.h with the following improvements, mostly minor, but a significant bug fix:
- Added implicit none.
- Simplified declaration of u10squ.
- Simplified treatment of N & C remineralization fluxes. (I made this change to allow the addition of a third detritus class in my branch of ROMS, but it's worth propagating back into the trunk.)
- The bug fix: defined a factor fiter = 1/BioIter(ng), applied in calculating diagnostic rate variables. Without this factor all such rate variables are overestimated when BioIter(ng) exceeds 1. I have checked this one out pretty thoroughly!
Change History (2)
by , 9 years ago
comment:1 by , 9 years ago
| Description: | modified (diff) |
|---|---|
| Resolution: | → Fixed |
| Status: | new → closed |
Yes, indeed. Good catch correcting this factor in the diagnostic terms. Also thank you for cleaning the code a little.
Note:
See TracTickets
for help on using tickets.
Corrected version of fennel.h