Opened 9 years ago

Closed 9 years ago

#658 closed bug (Fixed)

Corrected bug in mod_arrays.F

Reported by: arango Owned by: arango
Priority: major Milestone: Adjoint Based Algorithms
Component: Adjoint Version: 3.7
Keywords: Cc:

Description

  • A bug was corrected in mod_arrays.F when any of following CPP options were activated: AD_SENSITIVITY, IS4DVAR_SENSITIVITY, OPT_OBSERVATIONS, SENSITIVITY_4DVAR or SO_SEMI. The CLIMA(ng) structure was not allocated and initialize. A local switch LallocateClima was introduced:
    #if defined AD_SENSITIVITY   || defined IS4DVAR_SENSITIVITY || \
        defined OPT_OBSERVATIONS || defined SENSITIVITY_4DVAR   || \
        defined SO_SEMI
            LallocateClima=.TRUE.
    #else
            LallocateClima=.FALSE.
    #endif
    
    ...
              IF (LallocateClima.or.Lclimatology(ng)) THEN
                CALL allocate_clima (ng, LBi, UBi, LBj, UBj)
              END IF
    ...
    
              IF (LallocateClima.or.Lclimatology(ng)) THEN
                CALL initialize_clima (ng, tile)
              END IF
    
    Many thanks to Ilaria Lermano and Andy Moore for bringing this to our attention.
  • The random number generation routine gasdev.F was modified for portability with old F90 compilers that have problems with the intrinsic PACK function. Many thanks to Andy Moore for fixing this.

Change History (1)

comment:1 by arango, 9 years ago

Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.