Opened 10 years ago
Closed 10 years ago
#651 closed bug (Fixed)
Corrected minor bug in mod_stepping.F
Reported by: | arango | Owned by: | arango |
---|---|---|---|
Priority: | major | Milestone: | Release ROMS/TOMS 3.7 |
Component: | Adjoint | Version: | 3.7 |
Keywords: | Cc: |
Description
Corrected a minor bug in mod_stepping.F that was triggered when ADJUST_BOUNDARY was not activated in the 4D-Var algorithms. We need to have instead:
#if defined ADJUST_BOUNDARY || defined ADJUST_STFLUX || \ defined ADJUST_WSTRESS allocate ( Lfinp(Ngrids) ) Lfinp(1:Ngrids)=1 allocate ( Lfout(Ngrids) ) Lfout(1:Ngrids)=1 #endif
We were initializing Lbout instead Lfout above. A compilation error resulted if ADJUST_BOUNDARY is not activated. Many thanks to Julia Levin for bringing this to my attention.
I also corrected several comments that include ' or " in a line. Some compilers issue warnings. This is actually a bug in the compiler. It should not check commented statement like:
! H Q(k) = Q(k) T(k) + Gamma(k) q(k+1) e'(k) !
The above comment was changed to:
! H Q(k) = Q(k) T(k) + Gamma(k) q(k+1) transpose[e(k)] !
Note:
See TracTickets
for help on using tickets.