IMPORTANT: Updated reading LBC structure

[arango]

This ticket updates various files:

• The processing of the lateral boundary conditions structure (LBC) was not correct for biology and sediment models in nesting applications. We need to have instead the following statement in ecosim_inp.h, fennel_inp.h, nemuro_inp.h, npzd_Franks_inp.h, npzd_Powell_inp.h, and npzd_iron_inp.h:

              CASE ('LBC(isTvar)')
                IF (itracer.lt.NBT) THEN
                  itracer=itracer+1
                ELSE
                  itracer=1                      ! next nested grid
                END IF
                ifield=isTvar(idbio(itracer))
                Npts=load_lbc(Nval, Cval, line, nline, ifield, igrid,     &
       &                      idbio(iTrcStr), idbio(iTrcEnd),             &
       &                      Vname(1,idTvar(idbio(itracer))), LBC):
  

  We need to pass idbio(iTrcStr) and idbio(iTrcEnd) as arguments instead of just iTrcStr and iTrcEnd. Users need to make such changes to their additional ecosystem models that are not part of this repository!

• Similarly, sediment_inp.h was modified to have instead:

              CASE ('LBC(isTvar)')
                IF (itracer.lt.NST) THEN
                  itracer=itracer+1
                ELSE
                  itracer=1                      ! next nested grid
                END IF
                ifield=isTvar(idsed(itracer))
                Npts=load_lbc(Nval, Cval, line, nline, ifield, igrid,     &
       &                      idsed(iTrcStr), idsed(iTrcEnd),             &
       &                      Vname(1,idTvar(idsed(itracer))), LBC)
  

  We need to pass idsed(iTrcStr) and idsed(iTrcEnd) as a arguments.

• Modified read_phypar.F so the input parameters for NestLayers and GridsInLayer are equal to unity in non-nesting applications. Users may have the tendency to set such values to zero.

• Improved check_multifile.F to report when the input data time records from NetCDF files is not enough to finish the simulation. Persisting the last available data record is not possible in ROMS. Users need to provide enough data to cover the simulation period from start to finish. Many thanks to Kate Hedstrom for bringing this to my attention.