Opened 14 years ago

Closed 14 years ago

#413 closed bug (Fixed)

Corrected a problem when using get_state and netcdf_close

Reported by: arango Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.4
Component: Nonlinear Version: 3.4
Keywords: Cc:

Description

Corrected a couple of problems when calling routines get_state and netcdf_close:

  • The get_state routine has the following arguments:
          SUBROUTINE get_state (ng, model, msg, ncname, IniRec, Tindex)
    
    The IniRec argument is declared as intent(inout). This implies that it is illegal to pass a numeric value when calling this routine. We need to use a variable instead in several drivers. Many thanks to Brain Powell for bringing this to my attention. Some compiler may ignore this roule.
  • The routine netcdf_close has the following arguments:
        SUBROUTINE netcdf_close (ng, model, ncid, ncname, Lupdate)
    
    The ncname and Lupdate arguments are optional and only used when closing output files to update the bio_file global attribute in ecosystem model applications. This attribute will contain information about the path of the ecosystem model header file used during compilation. Recall that users can have a customized version of this file in their application directory. We need to be sure that Lupdate=.FALSE. when closing input files open for reading only. Otherwise, an error will occur. There were few files that needed this optional argument. Many thanks to Julia Levin for reporting this problem.

Change History (1)

comment:1 by arango, 14 years ago

Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.