Opened 14 years ago

Closed 14 years ago

#406 closed bug (Fixed)

radiation_stress.F angle incorrecly adjusted !!!!!

Reported by: jcwarner Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.4
Component: Nonlinear Version: 3.4
Keywords: Cc:

Description (last modified by arango)

Ticket 404 (src:ticket:404) incorrectly modified the wave angle in radiation_stress.F.

The angle in radiation_stress.F needs to be changed back to the correct form that I have used for the past 5 years:

       cff=1.5_r8*pi-Dwave(i,j)-angler(i,j)

Change History (1)

comment:1 by arango, 14 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed

Oops, this was an accident!!! I was experimenting with the SHOREFACE application to understand the 270 degree shift in my private branch. I was looking if the shift was in the physical direction of the waves. I didn't checked a curvilinear application which may complicates the directional shift. The original code was correct. I almost gave John an aneurysm... Sorry for that.

I forgot to change back the commented two lines in my private branch and this got propagated in my automatic updates of all repositories. Then, to make it worse I made and svn commit without specified the files that I wanted to change. This did all of them. I can happens. I just screw-up. The changes in src:ticket:404 to wrt_his.F were correct. The scale to those particular output fields was wrong and needs to be 1.0_r8.

Note: See TracTickets for help on using tickets.