Changes between Initial Version and Version 1 of Ticket #323


Ignore:
Timestamp:
06/25/09 19:41:03 (15 years ago)
Author:
arango
Comment:

No, really. The suggested changes will affect the perfect restart of the model. It is also possible that the perfect restart is not working in all sediment applications. However, this change is not recommended.

If the user wants to restart ROMS, it is wrong to recompile and change any of the CPP options. This will be not a restart However, the user still can use the restart file as an initial conditions in such cases that recompiling is needed. If this is the case, make sure that NRREC = 0. This will be deactivate the logic in checkvars.F to include the variables described in this post, which are used during restart.

This strategy is much better that modifying the code for an specific set-up.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #323

    • Property Resolution → WorksForMe
    • Property Status new → closed

  • Ticket #323 – Description

    initial v1  
    11Several users have had issues with some of the sediment related parameters when restarting. Two of these issues deal with morphology/bath and bedload.
    22
    3 1) Morphology/bath
    4 If an application is compiled without sed_morph, user runs an application, creates a restart. Then user activates sed_morph, recompiles, and restarts. This will result in an error because the ini file will not have var 'bath.' However, user just wants to start with bath = h and go forward.
    5 Suggested fix:
     31) Morphology/bath: If an application is compiled without '''SED_MORPH''', user runs an application, creates a restart. Then user activates SED_MORPH, recompiles, and restarts. This will result in an error because the initial file will not have var '''bath'''. However, user just wants to start with '''bath = h''' and go forward.
    64
    7 Modify checkvars.F and change lines ~420-430 from
     5Suggested fix: Modify '''checkvars.F''' and change lines ~420-430 from
    86
     7{{{
    98#if defined SEDIMENT && defined SED_MORPH
    109      IF (.not.have_var(idbath).and.get_var(idbath)) THEN
    … …  
    1514      END IF
    1615#endif
     16}}}
    1717
    1818to:
    1919
     20
     21{{{
    2022#if defined SEDIMENT && defined SED_MORPH
    2123      IF (.not.have_var(idbath).and.get_var(idbath)) THEN
    … …  
    2729      END IF
    2830#endif
     31}}}
    2932
    3033The added line of get_var bath = false will prevent the get_state to load it.
    3134
    32 2) bedload
    33 If a user runs an application that does not have bedload, creates a restart file.
    34 Then user activates bedload and recompiles and runs. This will result in an error because get_state is looking for bedload vars.
    35 Suggested fix:
    36 modify checkvers.F lines ~180-181 from
     352) Bedload: If a user runs an application that does not have '''BEDLOAD''', creates a restart file.
     36Then user activates '''BEDLOAD''' and recompiles and runs. This will result in an error because get_state is looking for bedload variables
     37
     38Suggested fix: Modify '''checkvars.F''' lines ~180-181 from
     39
     40{{{
    3741            get_var(idUbld(itrc))=.TRUE.
    3842            get_var(idVbld(itrc))=.TRUE.
    39 
     43}}}
    4044to
    41 
     45{{{
    4246            get_var(idUbld(itrc))=.FALSE.
    4347            get_var(idVbld(itrc))=.FALSE.
     48}}}
    4449
    4550This will prevent get_state to look for these vars. They are not currently used from the restart.