Changes between Initial Version and Version 1 of Ticket #313


Ignore:
Timestamp:
04/17/09 19:43:15 (15 years ago)
Author:
arango
Comment:

No, really. I actually screw-up! There is not a limitation on hc when using Vtransform=2. This is the advantage of the new transformation, it works for both hc < hmin and hc > hmin This was an issue in the old transformation (Vtransform=1) since we cannot have [h(x,y)-hc] to be negative because dz/ds is also negative!

The check here actually needs to be done in term of Vtransform: 

      IF (Vtransform(ng).eq.1) THEN
# if defined WET_DRY
        hc(ng)=MIN(MAX(hmin(ng),0.0_r8),Tcline(ng))
# else
        hc(ng)=MIN(hmin(ng),Tcline(ng))
# endif
      ELSE IF (Vtransform(ng).eq.2) THEN
        hc(ng)=Tcline(ng)
      END IF

and it is independent of the vertical stretching function (Vstretching). Then, the following constraint: 

        IF (hc(ng).le.hmin(ng)) THEN

needs to be removed for Vstretching=2,3.

I also corrected a bug associated with hc in ad_set_depth.F, tl_set_depth.F, and rp_set_depth.F. Many thanks to Andy Moore for discovering this bug which was introduced recently.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #313

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #313 – Description

    initial v1  
    1 If WET_DRY is defined and Vstretching 2 or 3 is used, ROMS will quit with an error message if there it topography above the level of the free-surface (which is generally the case in WET_DRY applications).
     1If '''WET_DRY''' is defined and Vstretching 2 or 3 is used, ROMS will quit with an error message if there it topography above the level of the free-surface (which is generally the case in '''WET_DRY''' applications).
    22
    33There are two problems:
    … …  
    2929should be removed, as in the Vstretching = 1 case.
    3030
    31 My modified set_scoord.F is attached.
     31My modified '''set_scoord.F''' is attached.
    3232