Typo in formula for SST nudging/OI

[mathieu]

In ROMS/Nonlinear/set_data.F line 1022 please replace

cff1=Zr*cff+pcoef_SST(order,ng)

by

cff1=Zr*cff1+pcoef_SST(order,ng)

The error results in incorrect extrapolation of sea surface temperature.

Also, in ROMS/Modules/mod_scalar.F the variables assi, pert, Prms and Prms are defined but not used anywhere.

This cause a problem because their allocation is not done correctly in line 1635-1637. After the loop on ng in line 1551-1584, the variable ng takes the value 2 (using ifort 10.1). The result is that the allocation is not correct and is detected with "-check bounds".

When running with no "-check bounds" with either ASSIMILATION_SST or NUDGING_SST and the error polynomial being 1 so that the temperature is not modified, the result is a blowup of the model caused by this memory error.

[arango]

Done. Thank you. I collapsed your two tickets into one. There is not need to submit multiple tickets. We appreciate a single ticket if the issues are related.