Opened 16 years ago

Closed 16 years ago

#187 closed bug (Fixed)

bug in shapiro filter option for LMD_BKPP

Reported by: kate Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.2
Component: Nonlinear Version: 3.2
Keywords: Cc:

Description

Some indexing problems - see attached patch.

Change History (1)

comment:1 by arango, 16 years ago

Resolution: → Fixed
Status: new → closed

The problem here is that we are passing a private variable to a routine that expects a global variable. I don't think that the code to smooth the depth of the bottom boundary layer, hbbl, is correct here. We need to smooth hbbl and not the thickness hbbl(:,:)-z_w(:,:,0), as we do for the hsbl: 

      CALL shapiro2d_tile (ng, tile, iNLM,                              &
     &                     LBi, UBi, LBj, UBj,                          &
#  ifdef MASKING
     &                     rmask,                                       &
#  endif
     &                     hbbl)

We need to be consistent with lateral boundary conditions, parallelism, and exchanges. Anyway, the smoothing (order=2) here is a linear operator. Thank you for reporting this problem.

Note: See TracTickets for help on using tickets.