Custom Query (986 matches)

• mod_ncparam.F: Added missing END SELECT to the metadata for the adjoint sensitivity of inert tracers. Many thanks to Brian Powell for bringing this issue to my attention.

• main2d.F: Moved the updating of time index iic(ng) to be bottom of the time stepping:

  !
  !-----------------------------------------------------------------------
  !  Advance time index and time clock.
  !-----------------------------------------------------------------------
  !
              DO ig=1,GridsInLayer(nl)
                ng=GridNumber(ig,nl)
                iic(ng)=iic(ng)+1
                time(ng)=time(ng)+dt(ng)
                step_counter(ng)=step_counter(ng)-1
                CALL time_string (time(ng), time_code(ng))
              END DO
  
            END DO STEP_LOOP
  

  I corrected this bug some time ago in my research code, but I forgot to fix the distributed code. Anyway, many thanks to Bradley Reed for ​reporting this issue.

• Update the Adjoint model to write out ad_W. A new output variable ad_W_sol to save the current ad_W solution before it is zeroed out. In ad_ouput.F, we have:

  !
  !  Save current adjoint solution for IO purposes.
  !
        DO k=0,N(ng)
          DO j=JstrR,JendR
            DO i=IstrR,IendR
              ad_W_sol(i,j,k)=ad_W(i,j,k)
            END DO
          END DO
        END DO
  

  Many thanks to Brian Powell for bringing this IO issue to our attention for his adjoint sensitivity studies.

• Corrected tides_date.F to include missing module reference:

        USE strings_mod,   ONLY : FoundError
  

  Many thanks to John Warner for reporting this problem.

I turned off the yaml_tree object creation switch IsCreated when deallocating object in routine yaml_tree_destroy. It is needed in the ROMS-JEDI interface.

!
!  Recall that Fortran 2003 standard allows deallocating just the
!  parent object to deallocate all array variables within its scope
!  automatically.
!
      IF (ASSOCIATED(self%list)) THEN
        self%IsCreated=.FALSE.
        DEALLOCATE (self%list)
      END IF