Custom Query (964 matches)

There is a bug in ana_nudgcoef.h in the MPI exchange of variables M3nudgcof and Tnudgcof. We need to have instead:

# ifdef SOLVE3D
!
      IF (LnudgeM3CLM(ng)) THEN
        CALL mp_exchange3d (ng, tile, model, 1,                         &
     &                      LBi, UBi, LBj, UBj, 1, N(ng),               &
     &                      NghostPoints, .FALSE., .FALSE.,             &
     &                      CLIMA(ng)%M3nudgcof)
      END IF
!
      IF (ANY(LnudgeTCLM(:,ng))) THEN
        CALL mp_exchange4d (ng, tile, model, 1,                         &
     &                      LBi, UBi, LBj, UBj, 1, N(ng), 1, NTCLM(ng), &
     &                      NghostPoints, .FALSE., .FALSE.,             &
     &                      CLIMA(ng)%Tnudgcof)
      END IF
# endif

Many thanks to Julia Levin for bringing this to my attention.

• Corrected a bug in ini_hmixcoef.F when computing visc2_p. I guess that I got distracted when I was coding this one. It usually happens when my phone rings and some enters my office. We need to have instead:

        cff=0.25_r8*cff
        DO j=JstrP,JendT
          DO i=IstrP,IendT
            visc2_p(i,j)=cff*(grdscl(i-1,j-1)+grdscl(i,j-1)+              &
       &                      grdscl(i-1,j  )+grdscl(i,j  ))
          END DO
        END DO
  

  Many thanks to Pan Feng for ​bringing this to my attention.

• Improved the checking of the units attribute in function check_file, which is called by check_multifile.F. I use instead:

        Nrec=var_Dsize(1)              ! time is a 1D array
        DO i=1,nvatt
          IF (TRIM(var_Aname(i)).eq.'units') THEN
            Tunits=TRIM(var_Achar(i))
            IF (INDEX(TRIM(var_Achar(i)),'day').ne.0) THEN
              Tscale=86400.0_r8
            ELSE IF (INDEX(TRIM(var_Achar(i)),'hour').ne.0) THEN
              Tscale=3600.0_r8
            ELSE IF (INDEX(TRIM(var_Achar(i)),'second').ne.0) THEN
              Tscale=1.0_r8
            END IF
          ELSE IF (TRIM(var_Aname(i)).eq.'calendar') THEN
            IF ((Nrec.eq.1).or.                                           &
       &        (INDEX(TRIM(var_Achar(i)),'none').ne.0)) THEN
              Lperpetual=.TRUE.
            END IF
          ELSE IF (TRIM(var_Aname(i)).eq.'cycle_length') THEN
            Lcycle=.TRUE.
          END IF
        END DO
  

  The intrinsic INDEX function is more appropriate here to search the time units in a string with additional words at the beginning or end of the string. Many thanks to John Luick for ​reporting this problem and giving more information.

• Corrected couple of bugs in the Shchepetkin boundary condition for 2D momentum in u2dbc_im.F and v2dbc_im.F. I also corrected the tangent linear, representer, and adjoint versions of these routines. Many thanks to Deepak Cherian and Sasha Shchepetkin for ​bringing this to my attention.

• Modified driver analytical.F so it is more robust when SOLVE3D is not defined. This is done to avoid loading header files that exclusive for 3D applications.

• Corrected several misspellings in the code documentation. Many thanks to Kate Hedstrom for reporting those.