Custom Query (964 matches)

In mod_scaras.F line 1570, replace

        SCALARS(ng) % IJwater((1:Lm(ng)+2)*(Mm(ng)+2),1:4) = 0

by

        SCALARS(ng) % IJwater(1:(Lm(ng)+2)*(Mm(ng)+2),1:4) = 0

The syntax of mp_scatter is modified by the READ_WATER option. Two calls to it in white_noise.F at lines 204 and 307 need to be corrected.

In wpoints,F on line 164, replace

# if defined READ_WATER || defined PROPAGATOR

by

# if defined READ_WATER || defined WRITE_WATER || defined PROPAGATOR

otherwise the mask is not defined.

In mod_param.F on line 159 replace

#if defined WRITE_WATER && defined MASKING

by

#if (defined WRITE_WATER || defined READ_WATER) && defined MASKING

The _FillValue logic introduced in ​src:ticket:222 broke when wetting and drying is activated. In this case, the bathymetry array becomes time-dependent and the tindex>0 and nVdim>2 logic to avoid masking no longer works. Recall that we cannot mask the bathymetry array in ROMS because h=0 in such areas and will give NaNs when dividing by h.

This implies that we need a more sophisticate logic to replace masked areas with _FillValue during IO. The less intrusive solution is put an optional argument (..., SetFillVal) to the nf_fwrite*d and def_var routines. Since optional arguments require an explicit interface, these routines were converted to modules. Therefore, several changes were needed in several of the IO routines.

This new logic is more elegant and allows for exception to land fill values in the future.

​src:ticket:214 included:

"Also the code to set the xxxx_FSOBC macros has been changed, eg this

#if (defined WEST_FSRADIATION  && defined WEST_FSNUDGING)  || \
     defined WEST_M2FLATHER    || defined WEST_FSCLAMPED   || \
     defined WEST_M2REDUCED
# define WEST_FSOBC
#endif

has been changed to

#if (defined WEST_FSRADIATION  && defined WEST_FSNUDGING)  || \
     defined WEST_M2FLATHER    || defined WEST_FSCLAMPED
# define WEST_FSOBC
#endif

The use of xxxx_M2REDUCED does not by itself mean that boundary surface-height data is required. For example it is possible to use xxxx_M2REDUCED with xxxx_FSCHAPMAN, in which case there is no need for xxxx_FSOBC. "

Well WHAT ABOUT THE POSSIBILITY THAT IT DID REQUIRE THE NEED FOR xxxx_FSOBC?????

The INLET_TEST uses :

#define FSOBC_REDUCED
#define NORTH_FSGRADIENT
#define NORTH_M2REDUCED

The ​src:ticket:214 change now removes the activation of the OBC flag, so the code never calls ana_fsobc and the tide is not added to the application!

Please modify the globaldefs.h file so that we CAN have xxxx_M2REDUCED and xxxx_FSOBC. This would be something like:

#if (defined WEST_FSRADIATION  && defined WEST_FSNUDGING)  || \
    (defined WEST_M2REDUCED    && defined FSOBC_REDUCED)   || \
     defined WEST_M2FLATHER    || defined WEST_FSCLAMPED
# define WEST_FSOBC
#endif

(same for N,S, and E).