VERY IMPORTANT: Updated Saddle Point 4D-Var

[arango]

• Updated the saddle-point 4D-Var (SP4DVAR) to include the option (CONCURRENT_KERNEL) that allows running the TLM and ADM split time interval concurrently. This option increases by two the number of processes needed to run an application.

For example, if Nsaddle=4, NtileI=2, and NtileJ=2, we will need 16 processes when CONCURRENT_KERNEL is off and 32 processes if it is activated.

   mpirun -np 16 romsM roms.in > & err &     (CONCURRENT_KERNEL off)
or
   mpirun -np 32 romsM roms.in > & err &     (CONCURRENT_KERNEL on)

For concurrent TLM and ADM, we also need to activate MPI and DISJOINTED.

• Fixed several logical errors in saddle_point.h, atimev.F, gmres.F, and precsp.F to achieve identical convergence values for Jobs.

• Modified the following files:

  ROMS/Adjoint/ad_initial.F
  ROMS/Drivers/is4dvar_ocean.h
  ROMS/Drivers/saddle_point.h
  ROMS/Drivers/w4dpsas_ocean.h
  ROMS/Modules/mod_parallel.F
  ROMS/Modules/mod_strings.F
  ROMS/Utility/atimesv.F
  ROMS/Utility/checkdefs.F
  ROMS/Utility/convolve.F
  ROMS/Utility/def_mod.F
  ROMS/Utility/gmres.F
  ROMS/Utility/inp_par.F
  ROMS/Utility/obs_initial.F
  ROMS/Utility/precsp.F
  ROMS/Utility/read_phypar.F
  ROMS/Utility/stdinp_mod.F
  ROMS/Utility/strings.F
  ROMS/Utility/tracing.F
  ROMS/Version
  

---

Many thanks to Andy Moore for his immense help in tracking and fixing the algorithm code and logical bugs.