Opened 12 months ago
Last modified 12 months ago
#947 closed bug
LuvSrc / LwSrc issue reported by Aurora Leeson — at Initial Version
| Reported by: | wilkin | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | Release ROMS/TOMS 4.2 |
| Component: | Nonlinear | Version: | 4.1 |
| Keywords: | Cc: |
Description
Forum post https://mobile.myroms.org/forum/viewtopic.php?p=24462#p24462 by Parker MacCready's student Aurora Leeson identifies what appears to be a bug in the processing of LuvSrc / LwSrc options in the particular combination that a user has a mix of BOTH LwSrc and LuvSrc sources (which is functionality we recently allowed following discussion with John Warner) AND not all the LuvSrc sources are in the u-direction (it is a quirky combination to trigger an error).
At line 1295 in step3d_uv.F
ELSE
should be
ELSEIF (INT(SOURCES(ng)%Dsrc(is)).eq.1)
with, implicitly, the Dsrc==2 is do nothing.
Presently, Dsrc==2 sources get activated here as uv-sources. This is because logical LuvSrc(ng) is global, and the encompassing
IF (LuvSrc(ng))
is true is ANY(LuvSrc), not specifically THIS source.
