Changes between Initial Version and Version 1 of Ticket #845


Ignore:
Timestamp:
03/03/20 20:52:48 (4 years ago)
Author:
arango
Comment:

Yes, indeed. Great catch! I modified read_phypar.F and inp_par.F.

  • Also, I corrected a typo in the documentation of each roms.in input script. We needed to have instead: 
    ! or in nested applications
!
!  Hadvection == U3       \                     ! temperature, Grid 1
!                HSIMT    \                     ! salinity,    Grid 1
!                U3       \                     ! temperature, Grid 2
!                HSIMT    \                     ! salinity,    Grid 2
!                U3       \                     ! temperature, Grid 3
!                HSIMT                          ! salinity,    Grid 3
!
!  Vadvection == C4       \                     ! temperature, Grid 1
!                HSIMT    \                     ! salinity,    Grid 1
!                C4       \                     ! temperature, Grid 2
!                HSIMT    \                     ! salinity,    Grid 2
!                C4       \                     ! temperature, Grid 3
!                HSIMT                          ! salinity,    Grid 3
    Many thanks to Pierre St-Laurent for ​reporting this typo in GLOSSARY section.
  • In addtion, I corrected ad_step2d_LF_AM3.h, ad_t3dmix4_geo.h, and ad_uv3dmix4_geo.h. The USE mod_ncparam was missing and necessary when the biharmonic mixing is activated. Many thanks to Xavier Couvelard for ​reporting this issue.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #845

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #845 – Description

    initial v1  
    1 The T and S advection schemes are read in read_phypar.F and ThreeGhostPoints is then set accordingly. It isn't until much later in inp_par.F that the biology, etc. advection schemes are read. If I have the old standard U3 for T and S and something fancier for biology, ThreeGhostPoints is not being set.
     1The T and S advection schemes are read in '''read_phypar.F''' and '''!ThreeGhostPoints''' is then set accordingly. It isn't until much later in '''inp_par.F''' that the biology, etc. advection schemes are read. If I have the old standard '''U3''' for T and S and something fancier for biology, '''!ThreeGhostPoints''' is not being set.