Opened 7 years ago
Closed 7 years ago
#750 closed bug (Fixed)
FRC_FILE set when no forcing file required — at Version 1
| Reported by: | m.hadfield | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | Release ROMS/TOMS 3.7 |
| Component: | Nonlinear | Version: | 3.7 |
| Keywords: | Cc: |
Description (last modified by )
The code in lines 659–714 of ROMS/include/globaldefs.h defines the symbol FRC_FILE. Then in lines 5576–5589 of ROMS/Utility/read_phypar.F the model checks for the existence of the file(s) specified by the FRCNAME entry in ocean.in. The globaldefs.h code defines FRC_FILE if, amongst other conditions, either SSH_TIDES or UV_TIDES is set: see line 700 if SOLVE3D is set and line 711 if it is not.
However, tidal parameters are now read from special tidal-forcing files (entry TIDENAME), not from ordinary forcing files as they were previously. The current code fails when tides are required but with no other forcings.
The references in ROMS/include/globaldefs.h to
(defined SSH_TIDES || defined UV_TIDES)
in lines 700 & 711 should be removed.
Change History (1)
comment:1 by , 7 years ago
| Description: | modified (diff) |
|---|---|
| Resolution: | → Fixed |
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Yes, great catch and explanation. I missed removing that logic from FRC_FILE.