Changes between Initial Version and Version 1 of Ticket #743


Ignore:
Timestamp:
08/10/17 04:13:15 (7 years ago)
Author:
arango
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #743

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #743 – Description

    initial v1  
    1 I think, in lines 626 and 701 of def_diags.F the pre-processor conditions should read as:
     1I think, in lines 626 and 701 of '''def_diags.F''' the pre-processor conditions should read as:
    22{{{
    33#if defined DIAGNOSTICS_BIO && defined BIO_FENNEL
    … …  
    88#ifdef BIO_FENNEL
    99}}}
    10 This can cause "undefined variable" errors for iDbio2 and iDbio3 during compilation, when other diagnostics but not DIAGNOSTICS_BIO are enabled in combination with BIO_FENNEL.
     10This can cause "undefined variable" errors for iDbio2 and iDbio3 during compilation when other diagnostics but not '''DIAGNOSTICS_BIO''' are enabled in combination with '''BIO_FENNEL'''.
     11
     12----
     13
     14Yes, thank you for bringing this problem to my attention.  I cleaned the logic in '''def_diags.F''', '''set_diags.F''', and '''wrt_diags.F'''.  I also added the 2D biological diagnotics for '''HYPOXIA_SRM'''.  It was not included in the above files.
     15
     16Also removed apostrophes in '''fennel.h''' documentation to suppress the warnings from '''ifort''' during compilation. I also cleaned a '''DIAGNOSTIC_BIO''' bug in '''hypoxia_srm.h'''.  We don't need the 3D diagnostics arrays in this simple model.
     17
     18----
     19
     20Fixed '''OMP''' directives in '''initial.F''', '''ad_initial.F''', '''rp_initial.F''', and '''tl_initial.F''' when the 4D-Var algorithms are activated.  This bug is of no consequence since we cannot run any of the adjoint-based algorithms in shared-memory ('''OpenMP''').