Opened 7 years ago

Last modified 7 years ago

#742 closed bug

Faulty proprocessor logic for DIAGNOSTICS_BIO — at Initial Version

Reported by: m.hadfield Owned by:
Priority: major Milestone: Release ROMS/TOMS 3.7
Component: Nonlinear Version: 3.7
Keywords: Cc:

Description

In ROMS/Include/globaldefs.h at lines 765-768 the effect of the following lines... 

#if (!defined BIO_FENNEL  && defined DIAGNOSTICS_BIO) || \
    (!defined HYPOXIA_SRM && defined DIAGNOSTICS_BIO)
#  undef DIAGNOSTICS_BIO
#endif

...is to undefine DIAGNOSTICS_BIO unless both BIO_FENNEL and HYPOXIA_SRM are defined.

I suggest... 

#if defined DIAGNOSTICS_BIO && !(defined BIO_FENNEL || HYPOXIA_SRM)
#  undef DIAGNOSTICS_BIO
#endif

...or its syllogistic equivalent.

Change History (0)

Note: See TracTickets for help on using tickets.