Changes between Initial Version and Version 1 of Ticket #649


Ignore:
Timestamp:
11/19/14 23:14:22 (10 years ago)
Author:
arango
Comment:

Thank you for correcting this routine.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #649

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #649 – Description

    initial v1  
    1 TS_MPDATA developed a tiling bug in the mpdata_adiff.F routine when all the ranges were recoded to be more general.  There were only afew places, but it was critical. I found the offending lines and provided a routine (attached) with correct ranges.
     1'''TS_MPDATA''' developed a tiling bug in the '''mpdata_adiff.F''' routine when all the ranges were recoded to be more general.  There were only a few places, but it was critical. I found the offending lines and provided a routine (attached) with correct ranges.
    22
    3 Also, i added a new flag
    4 TS_MPDATA_LIMIT
    5 When this option is activated, the upwind corrector fluxes are further limited to be a factor of 0.25 times the computed corrector flux. We have found that in some limited applications with rapidly varying topography and strong tracer gradients, that the upwind flux was creating some oscillations. This limits that behavior.  Of course, if you set the fac to = 0.0, then the method is purely upwind.
    6 
    7 -john
     3Also, i added a new flag '''TS_MPDATA_LIMIT'''. When this option is activated, the upwind corrector fluxes are further limited to be a factor of '''fac = 0.25''' times the computed corrector flux. We have found that in some limited applications with rapidly varying topography and strong tracer gradients, that the upwind flux was creating some oscillations. This limits that behavior.  Of course, if you set the '''fac = 1.0''', then the method is purely upwind.
    84
    95