psi mask computation

[jcwarner]

During initialization, the mask at PSi_points is recomputed in metrics.F. The range for this is:

      DO j=Jstr,Jend
        DO i=Istr,Iend
          IF ((rmask...   THEN
            pmask(i,j)=1.0_r8
          ...
        END DO
      END DO

But the pmask has a range from Istr:Iend+1, and Jstr:Jend+1. So I think this range should be Istr,Iend+1 and Jstr,Jend+1.

[arango]

Yes, good catch. However, the I- and J-range needs to be instead:

      DO j=Jstr,JendR
        DO i=Istr,IendR
          IF ((rmask...   THEN
            pmask(i,j)=1.0_r8
          ...
        END DO
      END DO

Notice that periodic boundary conditions and MPI exchange is done after the re-computation for free-slip/no-slip. The Iend+1 and Jend+1 has a different meaning in tiled configurations.

Warning: This change to the code will affect your solution because of a change to the PSI mask at the grid edges.