Changes between Initial Version and Version 1 of Ticket #40


Ignore:
Timestamp:
05/25/07 22:34:04 (17 years ago)
Author:
arango
Comment:

Well, MY_APPLICATION was intended as a dummy segment of code showing how to set-up a particular application. I was not expecting any user to actually use this a CPP option in ROMS. However, your point is well taken and you indeed may use such capability. If this is the case, then there is a typo in ana_m3clima.h and we need to remove this option from ROMS/Functionals. I missed those occurences of MY_APPLICATION in that directory.

You can post the ticket in either TRAC webpage since John, Kate and I get e-mail notification of every ticket that it is posted. However, I prefer to put all bug ticket related to ROMS kernel in ​https://www.myroms.org/projects/src and leave the other TRAC website ​https://www.myroms.org/projects/cstm to CSTM related ticket.

At the end it doesn't matter that much were the ticket is posted but how it is resolved.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #40

    • Property Resolution → fixed
    • Property Status new → closed

  • Ticket #40 – Description

    initial v1  
    1 I think {{{MY_APPLICATION}}} should be defined in {{{/User/Functionals/ana_m3clima.h}}}, instead of {{{MY_APPLICATION*S*}}}
     1I think '''MY_APPLICATION''' should be defined in '''User/Functionals/ana_m3clima.h''', instead of '''MY_APPLICATION*S*'''.
    22
    3 Also, should {{{MY_APPLICATION}}} be defined anywhere in {{{/ROMS/Functionals/*}}}? I don't think so. It appears in {{{/ROMS/Functionals/ana_initial.h}}} and {{{ana_m3clima.h}}}. (I found these with {{{grep -r MY_APPLICATION *}}}). That breaks one approach for running my own application (call it {{{CHRIS}}}), which is to copy {{{/User/Functionals/ana_whatever.h}}} into a directory with all of the {{{CHRIS}}} stuff, then place appropriate code inside
     3Also, should '''MY_APPLICATION''' be defined anywhere in '''ROMS/Functionals/*'''? I don't think so. It appears in '''ROMS/Functionals/ana_initial.h''' and '''ana_m3clima.h'''. (I found these with '''grep -r MY_APPLICATION *'''). That breaks one approach for running my own application (call it '''CHRIS'''), which is to copy '''User/Functionals/ana_whatever.h''' into a directory with all of the '''CHRIS''' stuff, then place appropriate code inside
    44{{{
    55#if defined MY_APPLICATION
    … …  
    77#endif
    88}}}
    9 I then put {{{#define MY_APPLICATION}}} at the top of {{{chris.h}}}. That seems easier than always adding another test for the case at hand.
     9I then put #define '''MY_APPLICATION''' at the top of '''chris.h'''. That seems easier than always adding another test for the case at hand.
    1010
    11 Finally, I found this in {{{ROMS_SED}}} trunk...and posted this ticket on the CSTM TRAC system, but it did not look like that TRAC system was being used...where should we post bugs when we find them in the ROMS_SED trunk?
     11Finally, I found this in '''ROMS_SED''' trunk... and posted this ticket on the CSTM TRAC system, but it did not look like that TRAC system was being used... where should we post bugs when we find them in the ROMS_SED trunk?