Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#274 closed defect (Invalid)

Avoid time checking on frequency variables — at Version 1

Reported by: arango Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.2
Component: Nonlinear Version: 3.2
Keywords: Cc:

Description (last modified by arango)

I added code in get_cycle.F to avoid checking available time for variables where the time is in terms of frequency. This is the case for tide forcing variables. The previous logic resulted in error under special conditions as reported in the forum.

Also corrected few typos in normarlization.F, ad_variability.F, state_copy.F, and state_initialize.F. Many thanks to Gregoire Broquet for reporting these typos.

I added new options when compiling with ifort to facilitate the trapping of uninitialized variables:

    -check uninit -ftrapuv

These are good flags to have when debugging. I just discovered an uninitialized ad_cff1 in ad_ini_fields.F. This can be a potential adjoint bug depending how compilers treat uninitialized variables.

Change History (1)

comment:1 by arango, 15 years ago

Description: modified (diff)
Resolution: Done
Status: newclosed
Note: See TracTickets for help on using tickets.