Opened 16 years ago

Closed 16 years ago

#210 closed bug (Fixed)

ESTUARY_TEST sediment-related bugs — at Version 1

Reported by: m.hadfield Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.2
Component: Nonlinear Version: 3.2
Keywords: Cc:

Description (last modified by arango)

In sed_bed.F and sed_fluxes.F, when ASSUMED_SHAPE is not defined the following appear:

   real(r8), intent(inout) :: ero_flux(LBi:UBi,LBj:UBj,:) 
   real(r8), intent(inout) :: settling_flux(LBi:UBi,LBj:UBj,:) 

That should be

   real(r8), intent(inout) :: ero_flux(LBi:UBi,LBj:UBj,NST) 
   real(r8), intent(inout) :: settling_flux(LBi:UBi,LBj:UBj,NST) 

Corrected files attached.

Also in subroutine readPhyPar, file in_par.F, I'm getting bounds-checking areas in this area of the code

          ELSE IF (TRIM(KeyWord).eq.'Hout(idBott)') THEN
            IF (MAXVAL(idBott).eq.0) THEN
              WRITE (out,280) 'idBott'
              STOP
            END IF
            Npts=load_l(Nval, Cval, MBOTP*Ngrids, Lbottom)
            DO ng=1,Ngrids
              DO itrc=1,MBOTP
                i=idBott(itrc)
>>error here>>  Hout(i,ng)=Lbottom(itrc,ng)
              END DO
            END DO

because for itrc=17, idBott(itrc) is equal to zero.

Change History (3)

by m.hadfield, 16 years ago

Attachment: sed_bed.F added

by m.hadfield, 16 years ago

Attachment: sed_fluxes.F added

comment:1 by arango, 16 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed

Yes, thank you. The problem with idBott(itrc) for itrc=17 is a typo in mod_ncparam.F at line 1494. We need idefx instead idrfx.

Note: See TracTickets for help on using tickets.