Changes between Initial Version and Version 1 of Ticket #162


Ignore:
Timestamp:
07/01/08 18:17:23 (16 years ago)
Author:
arango
Comment:

Yes, good catch! Well, the original COARE code was 1-dimensional so the problem was when it was converted to two-dimensional quantities. I do agree with you that the best way to solve this problem is to set Itermax = 3 for the similarity theory look tables. This is the less complicated solution for the adjoint version of this routine.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #162

    • Property Resolution → Fixed
    • Property Status new → closed

  • Ticket #162 – Description

    initial v1  
    1 Small tiling bug in Nonlinear/bulk_flux due to variable itermax.
    2 The variable itermax is set in an "i" loop.
    3 Itermax takes a value of 1 or 3, depending on the last setting in the "i" loop.
    4 After that i loop completes, we have
     1Small tiling bug in '''Nonlinear/bulk_flux.F''' due to variable '''Itermax'''. The variable '''Itermax''' is set in an '''i''' loop. '''Itermax''' takes a value of 1 or 3, depending on the last setting in the '''i''' loop.
    52
     3After that '''i''' loop completes, we have
     4{{{
    65        DO Iter=1,IterMax
    76          DO i=Istr-1,IendR
    87.....
     8}}}
    99
    10 Well, the number of iterrations for any given i-tile will depend on the last value of itermax. Thus, the values in an i-tile will depend on how it is tiled.
    11 Solution: dimension itermax(private_1d_scratch_array) and compute itermax(i).
    12 Then change the order of the do loops as:
     10Well, the number of iterations for any given i-tile will depend on the last value of '''Itermax'''. Thus, the values in an i-tile will depend on how it is tiled.
     11
     12Solution: dimension '''Itermax(private_1d_scratch_array)''' and compute '''Itermax(i)'''. Then change the order of the do loops as:
     13{{{
    1314        DO i=Istr-1,IendR
    1415          DO Iter=1,IterMax(i)
    1516.....
     17}}}
    1618
    17 --- or---
    18 just set itermax = 3 and be done with it (?).
     19'''or''' just set '''Itermax = 3''' and be done with it (?).
    1920