Opened 16 years ago

Closed 16 years ago

#155 closed bug (Fixed)

maxrho/maxspeed bug for multiple serial tiles — at Version 1

Reported by: kate Owned by: arango
Priority: major Milestone: Release ROMS/TOMS 3.2
Component: Nonlinear Version: 3.2
Keywords: Cc:

Description (last modified by arango)

The variables maxrho and maxspeed are local to diag.F and therefore not remembered from one tile to the next. Diag will do the wrong thing unless a SAVE is added for them, or they are put in a module with avgke and friends.

Also, the reduction on them is wrong. They are being added instead of maxed.

Change History (2)

by kate, 16 years ago

Attachment: patch.diag added

patch

comment:1 by arango, 16 years ago

Description: modified (diff)
Resolution: Fixed
Status: newclosed

Yes, good catch. It is better to define these variables in mod_scalars.F. I also converted to a vector (1:Ngrids) to for multiple levels of nesting.

Note: See TracTickets for help on using tickets.