Custom Query (986 matches)

This code:

 726       IF (SOUTH_WEST_TEST) THEN
 727 #   ifdef WEST_FSOBC
 728         DO j=JLB,JUB
 729           cff=Dcrit(ng)-GRID(ng)%h(0,j)
 730           IF (BOUNDARY(ng)%zeta_west(j).le.cff) THEN
 731             BOUNDARY(ng)%zeta_west(j)=cff
 732           END IF
 733         END DO
 734 #   endif

becomes:

   292       IF (.true.) THEN
    293         DO j=JLB,JUB
    294           cff=Dcrit(ng)-GRID(ng)%h(0,j)
    295           IF (BOUNDARY(ng)%zeta_west(j).le.cff) THEN
    296             BOUNDARY(ng)%zeta_west(j)=cff
    297           END IF
    298         END DO

running in parallel, I get:

0: Subscript out of range for array grid%h (set_data.f90: 294)
    subscript=0, lower bound=159, upper bound=242, dimension=2
0: Subscript out of range for array grid%h (set_data.f90: 294)
    subscript=83, lower bound=0, upper bound=82, dimension=2
0: Subscript out of range for array grid%h (set_data.f90: 294)
    subscript=0, lower bound=559, upper bound=642, dimension=2

and so on.

Corrected missing CPP directives in routines tl_step3d_uv.F and ad_step3d_uv.F. This bug was introduced in ​src:ticket:346. Many thanks to Gregoire Broquet and Andy Moore for reporting this.

I also corrected a small defect in tl_balance.F and ad_balance.F. We need to have:

      DO j=JstrR,JendR
        DO i=IstrR,IendR
          DO k=1,N(ng)
            cff=0.5_r8*(dTdz(i,j,k-1)+dTdz(i,j,k))
            IF (ABS(cff).lt.dTdz_min) THEN
              dzdT=0.0_r8
            ELSE
              dzdT=1.0_r8/cff
            END IF
            dSdT(k)=(0.5_r8*(dSdz(i,j,k-1)+                             &
     &                       dSdz(i,j,k  )))*dzdT
          END DO

instead of:

      DO j=JstrR,JendR
        DO i=IstrR,IendR
          DO k=1,N(ng)
            IF (ABS(dTdz(i,j,k)).lt.dTdz_min) THEN
              dzdT=0.0_r8
            ELSE
              dzdT=1.0_r8/(0.5_r8*(dTdz(i,j,k-1)+                       &
     &                             dTdz(i,j,k  )))
            END IF
            dSdT(k)=(0.5_r8*(dSdz(i,j,k-1)+                             &
     &                       dSdz(i,j,k  )))*dzdT
          END DO

Corrected several serious bugs in Matlab script uv_balance.m which computes the unbalanced standard deviation used to scale the 4DVar error convariance matrix when the balance operator is activated.

I am now getting identical solutions when I compare the Matlab compact notation (much faster) against the Fortran-like statements with for loops.