Custom Query (986 matches)

Warning: This is a very important fix when your input files are not CF compliant. Recall that get_ngfld is used to process boundary, river, and tide data.

Corrected a bug in file get_ngfld.F around line 193. We need to use n_vdim instead of n_dim in the DO loop:

!
!  If Nrec=0, input file is not CF compliant, check variable dimension
!  to see if the dimension contains the "time" string.
!
            IF (got_time.and.(Nrec.eq.0)) THEN
              DO i=1,n_vdim
                IF (INDEX(TRIM(var_Dname(i)),'time').ne.0) THEN
                  Nrec=var_Dsize(i)
                END IF
              END DO
            END IF

This only occurs when input file is not CF compliant with the time dimension. In the previous versions you will get an out of bounds error for variable var_Dname.

I also updated several of the CDL files to be CF compliant.

Corrected a bug in set_vbc.F when computing the quadratic bottom stress for ice cavities (ICESHELF and UV_QDRAG). Around line 353 we need

cff2=SQRT(u(i,j,N(ng),nrhs)*u(i,j,N(ng),nrhs)+cff1*cff1)

instead. Many thanks to Ben Galton-Fensi and Michael Dinniman for ​reporting this bug.

Also corrected couple of typos in set_scoord.F when reporting vertical stretching values to standard output. Many thanks to John Luick for ​bringing this issue to my attention.

Several corrections were made to tl_npzd_iron.h, rp_npzd_iron.h, and ad_npzd_iron.h. These routines now pass the sanity checks and Picard iterations test. Many thanks to Andy Moore for making these corrections and Jerome Fiechter for carrying out the test.

I also corrected the light formulation in tl_npzd_Powell.h, rp_npzd_Powell.h, and ad_npzd_Powell.h. This new formulation was not correctly adjointed.