Custom Query (986 matches)

The local variable Iinp was not assigned in routine wrt_impulse.F.

Also corrected a problem in build.bash when the macro definitions are commented out. We need to add a colon when testing if the macro expands to NULL:

We need to use:

if [ -n "${USE_MPIF90:+1}" ]; then
  ...
fi

indead of

if [ -n "${USE_MPIF90+1}" ]; then
  ...
fi

Many thanks to David Robertson for fixing this problem.

The switch LdefTLM used to create the tangent history NetCDF file in tl_initial.F was accidentally removed in ​src:ticket:255. Many thanks to Gregoire Broquet for reporting this bug.

Updated several algorithms:

• Replaced routines mp_gather and mp_scatter with mp_gather2d, mp_gather3d, mp_scatter2d, and mp_scatter3d. It is better to split these routines into 2D and 3D array processing to follow better the strong-typing rules in module distribute.F.
• Removed the need to provide an input tangent linear model initial conditions file (ITLname) in weak-constraint data assimilation algorithm (W4DPSAS and W4DVAR). This file is now created internally in drivers w4dpsas_ocean.h and w4dvar_ocean.h.
• Corrected bug in zetabc.F when WEST_FSRADIATION is activated. Change index kstp with know in the computation of local variable grad. Many thanks to Francesco Nencioli for ​reporting this problem.