Custom Query (986 matches)

This the last stage of the upgrade for the IS4DVAR algorithm. The intermediate IS4DVAR driver Drivers/is4dvar_ocean.h and its associated conjugate gradient algorithm Utility/cgradient.h are removed and not longer supported. This algorithm computed incorrectly the background and observation cost functions when more that one outer loop is used (Nouter >1). This is corrected in the new algorithm.

From now on, only Drivers/is4dvar_lanczos_ocean.h and Utility/cgradient_lanczos.h will be supported and becomes the default IS4DVAR algorithm. No longer the option LANCZOS is needed to activate this algorithm. Several parameters and sections of code from the old driver are also removed for clarity and to avoid confusion.

It turns out that we need to follow the point association rules for array IJwater in the call to mp_scatter in input routines nf_fread2d.F, nf_fread3d.F, and nf_fread4d.F when the READ_WATER option is activated. Although these input routines are not inside a module, the mp_scatter routine is and this array is passed as a pointer using the SCALARS(ng)%IJwater synthax. This problem is also found in routine white_noise.F.

This is similar to ​src:ticket:228 and discovered using ifort 10.1. Many thanks to Mathieu Dutour for reporting this problem.

A memory leak was found in nf_fread2d.F when the option READ_WATER was activated. To avoid such leaks in the future and facilitate debugging nf_fread2d.F, nf_fread3d.F, and nf_fread4d.F were put inside modules. Therefore, all the routines that use these input routines were changed to have the correct pointer association in the arguments. Currently, all the generic NetCDF interface is inside modules.

Corrected bugs in wpoints.F for serial and shared-memory applications.