Custom Query (964 matches)

I am a relatively inexperienced ROMS user so my apologies if I am in error here. I recently updated my ROMS code to the most recent version and was surprised to find the following code intact:

!  Compute specific humidity, Q (kg/kg).
!
          IF (RH.lt.2.0_r8) THEN                       !RH fraction
            cff=cff*RH                                 !Vapor pres (mb)
            Q(i)=0.62197_r8*(cff/(PairM-0.378_r8*cff)) !Spec hum (kg/kg)
          ELSE          !RH input was actually specific humidity in g/kg
            Q(i)=RH/1000.0_r8                          !Spec Hum (kg/kg)
          END IF

I believe that the two blocks of code in the if/else statement should be swapped. Note that this block of code is the subject of several posts on the roms forum, e.g.: ​https://www.myroms.org/forum/viewtopic.php?f=3&t=2333

As John Wilkin explains in that post on the forum, this piece of legacy code appears to check whether the user inputs relative humidity (in %) or specific humidity (in g/kg). If "RH" < 2, ROMS concludes that the user has provided specific humidity in g/kg, but in that case it should go to the "else" statement and divide RH by 1000 to obtain Q in kg/kg.

If the user has provided relative humidity in per cent, then ROMS executes the code in the "else" block, but that is the case where ROMS should execute the code in the "if" block.

Tom

The dynamic and automatic memory usage is underestimated in the standard output report because of the local variable size2d needs to be bigger in several modules.

We need to have:

       size2d=REAL((UBi-LBi+1)*(UBj-LBj+1),r8)

instead of
      
       size2d=REAL((UBi-LBi)*(UBj-LBj),r8) 

for the horizontal array size.

Added svn properties and Id to few files to fix few issues in the git repository.