Custom Query (964 matches)

In the conversion to the new open boundary conditions logical flags a bug was introduced in the block:

#if defined ESTUARY_TEST
      IF (LBC(ieast,isUbar,ng)%acquire.and.                             &
     &    LBC(ieast,isVbar,ng)%acquire.and.                             &
     &    DOMAIN(ng)%Western_Edge(tile)) THEN ...
        ...

The test should be on LBC(iwest ... not east.

Version 4.0 of Gnu make is now available, so the NEED_VERSION variable in the ROMS makefile needs to be changed to

NEED_VERSION := 3.80 3.81 3.82 3.82.90 4.0

Not sure why this was not seen before. But most likely because the idiag index was not exceeded. There is a bug in step3d_uv.F, line 937 needs to be in an idiag loop the code now has:

# if defined DIAGNOSTICS_UV && defined MASKING
          DO k=1,N(ng)
            DO i=Istr,Iend
              DiaV3wrk(i,j,k,idiag)=DiaV3wrk(i,j,k,idiag)*vmask(i,j)
            END DO
          END DO
# endif

but it really needs to be:

# if defined DIAGNOSTICS_UV && defined MASKING
          DO k=1,N(ng)
            DO i=Istr,Iend
              DO idiag=1,NDM3d
                DiaV3wrk(i,j,k,idiag)=DiaV3wrk(i,j,k,idiag)*vmask(i,j)
              END DO
            END DO
          END DO
# endif