Custom Query (986 matches)

OpenMP supports the THREADPRIVATE(var) pragma so variables can be make private to a thread. We use this directive in ROMS only for the time profiling variables proc, Cstr, and Cend. As implemented in ROMS, we used common blocks for the var argument. Nowadays, this is problematic in some compilers like gfortran. Since the newer versions of OpenMP is mature nowadays in mostly all the compiler that support it, we are removing the common block and just pass the variable names as arguments.

So we are changing mod_parallel.F from:

#ifdef _OPENMP
        common /process/ proc
!$OMP THREADPRIVATE (/process/)
        common /wallclock/ Cstr, Cend
!$OMP THREADPRIVATE (/wallclock/)
#endif

to

#ifdef _OPENMP
!$OMP THREADPRIVATE (proc)
!$OMP THREADPRIVATE (Cstr, Cend)
#endif

Many thanks to Mark Hadfield for suggesting this change. I tested this change with the pgf90, ifort, and gfortran compilers.

I also updated the build.sh and build.bash scripts to allow the user to set the paths of the libraries required by ROMS using environment variables which take precedence to the values specified in the makefile macro definitions file (Compilers/*.mk).

I also changed the Compilers/*.mk to include the missing token ESMF_COMM in the ESMF_SUBDIR definition. There were also missing some flags for OpenMP option in the FFLAGS definition.

Please modify ROMS/External/coupling_inlet_test.in from

 Nexport(waves) = 5

  Export(waves) = Wdir  \
                  Wamp  \
                  Wlen  \
                  Wptop \
                  Wpbot

 Nimport(ocean) = 5

  Import(ocean) = Wdir  \
                  Wamp  \
                  Wlen  \
                  Wptop \
                  Wpbot

to

 Nexport(waves) = 6

  Export(waves) = Wdir  \
                  Wamp  \
                  Wlen  \
                  Wptop \
                  Wpbot \
                  Wubot

 Nimport(ocean) = 6

  Import(ocean) = Wdir  \
                  Wamp  \
                  Wlen  \
                  Wptop \
                  Wpbot \
                  Wubot

This application uses the SSW_BBL and requires the bottom orbital velocity to be sent from Waves to Ocean.

In ROMS/Functionals/ana_tobc.h, lines 28-32 are

      CALL ana_tobc_tile (ng, tile, model,                              &
     &                    LBi, UBi, LBj, UBj, nstp(ng),                 &
     &                    IminS, ImaxS, JminS, JmaxS,),                 &
     &                    GRID(ng) % z_r,                               &
     &                    OCEAN(ng) % t)

There's a redundant ")" in line 30.