Custom Query (964 matches)

Forward runs (eg UPWELLING) in serial and OpenMP mode no longer print data about grid spacing and Courant number, i.e., instead of this

 Power filter parameters, Fgamma, gamma =  0.28400   0.18933

 Minimum X-grid spacing, DXmin =  1.00000000E+00 km
 Maximum X-grid spacing, DXmax =  1.00000000E+00 km
 Minimum Y-grid spacing, DYmin =  1.00000000E+00 km
 Maximum Y-grid spacing, DYmax =  1.00000000E+00 km
 Minimum Z-grid spacing, DZmin =  1.57503054E+00 m
 Maximum Z-grid spacing, DZmax =  2.30290891E+01 m

 Minimum barotropic Courant Number =  2.22358627E-01
 Maximum barotropic Courant Number =  5.42494240E-01
 Maximum Coriolis   Courant Number =  2.47800000E-02


 Maximum grid stiffness ratios:  rx0 =   6.931666E-02 (Beckmann and Haidvogel)
                                 rx1 =   1.188435E+00 (Haney)

we get this

 Power filter parameters, Fgamma, gamma =  0.28400   0.18933

 Maximum grid stiffness ratios:  rx0 =   6.931666E-02 (Beckmann and Haidvogel)
                                 rx1 =   1.188435E+00 (Haney)

MPI runs still produce the full output.

As far as I can tell, this change occurred some time between 21 July and 14 August.

When I run the FLT_TEST case with MPI enabled and in debug mode (compiler is G95), it hits an out-of-bounds error in subroutine wclock_on.

The stack trace is

      At line 45 of file timers.f90
Traceback: (Innermost first)
   Called from line 330 of file distribute.f90
   Called from line 262 of file inp_par.f90
   Called from line 94 of file ocean_control.f90
   Called from line 97 of file master.f90
Fortran runtime error: Array element out of bounds: 2 in (1:1), dim=3

The offending line is in subroutine wclock_on (source file timers.f90):

      Cstr(region,MyModel,ng)=my_wtime(wtime)

and the problem is that ng is equal to 2, which is out of bounds for array Cstr. The value of ng = 2 is being passed to this routine by subroutine mp_bcasti_s (file distribute.f90), which is passed it by subroutine inp_par (file inp_par.f90).

Here is the block of code in inp_par where mpi_bcasti_s is called (via the interface mp_bcasti):

!
!-----------------------------------------------------------------------
!  Check C-preprocessing options and definitions.
!-----------------------------------------------------------------------
!
      IF (Master) THEN
        CALL checkdefs
        CALL my_flush (out)
      END IF
      CALL mp_bcasti (ng, model, exit_flag, 1)
      IF (exit_flag.ne.NoError) RETURN

In subroutine inp_par there are several loops of the form

      DO ng=1,Ngrids
        ...
      END DO

but this block of code is not inside one of these loops, so ng is left with the value it had on exit from the previous loop, ie Ngrids+1.

So I presume the solution is to wrap this in a loop

      CALL mp_bcasti (ng, model, exit_flag, 1)

The attached zip file contains modified versions of three platform-specific make files: CYGWIN-g95.mk, CYGWIN-gfortran.mk, Linux-g95.mk. The changes are:

• CYGWIN files now have MPI support. I have tested this with MPICH2 using the mpif90 script.

• G95 files now use the "-ffree-line-length-huge" flag for the targets mod_ncparam.o, mod_strings.o and analytical.o. This is the G95 counterpart of Gfortran's "-ffree-line-length-huge"