Custom Query (964 matches)

Lines 651-653 in mod_netcdf.F are:

            DO j=1,LEN(var_Achar(1))
              var_Aname(i)(j:j)=' '
            END DO

That should be

            DO j=1,LEN(var_Achar(1))
              var_Achar(i)(j:j)=' '
            END DO

This error is detected when compiler bounds checking is enabled.

The LMD_TEST case (which I am using as a model for a 1-D test of some biological code) has STATIONS defined but no stations file. Attached are an appropriately named stations file and a model input file that points to it.

OpenMP supports the THREADPRIVATE(var) pragma so variables can be make private to a thread. We use this directive in ROMS only for the time profiling variables proc, Cstr, and Cend. As implemented in ROMS, we used common blocks for the var argument. Nowadays, this is problematic in some compilers like gfortran. Since the newer versions of OpenMP is mature nowadays in mostly all the compiler that support it, we are removing the common block and just pass the variable names as arguments.

So we are changing mod_parallel.F from:

#ifdef _OPENMP
        common /process/ proc
!$OMP THREADPRIVATE (/process/)
        common /wallclock/ Cstr, Cend
!$OMP THREADPRIVATE (/wallclock/)
#endif

to

#ifdef _OPENMP
!$OMP THREADPRIVATE (proc)
!$OMP THREADPRIVATE (Cstr, Cend)
#endif

Many thanks to Mark Hadfield for suggesting this change. I tested this change with the pgf90, ifort, and gfortran compilers.

I also updated the build.sh and build.bash scripts to allow the user to set the paths of the libraries required by ROMS using environment variables which take precedence to the values specified in the makefile macro definitions file (Compilers/*.mk).

I also changed the Compilers/*.mk to include the missing token ESMF_COMM in the ESMF_SUBDIR definition. There were also missing some flags for OpenMP option in the FFLAGS definition.