Custom Query (986 matches)

• Corrected a small bug in the implementation of the point sources as a volume vertical influx (LwSrc) in step3d_t.F and TLM, RPM, and ADM versions. We need to use the point source location (Isrc, Jsrc) when computing the area scale:

                      cff=dt(ng)*pm(Isrc,Jsrc)*pn(Isrc,Jsrc)
  

  Many thanks to John Warner for ​bringing this to my attention.

• Added the -liomp5 library to Compilers/Linux-ifort.mk configuration file. It is required by newer versions of ifort.

• Corrected missing arguments in convolve.F. Many thanks to Stefan Riha for ​reporting this problem.

This is a simple update:

• Added make configuration Darwin-nag.mk, which allows compiling/linking ROMS with the NAGFOR compiler on Apple Silicon (Arm v8 processor) Macs. In addition, we corrected several minor typos that the NAGFOR compiler didn't like. Many thanks to David Robertson for getting this to work.

• Corrected typos in gls_corstep.F and lmd_vmix.F routines. Many thanks to Michael Dinniman for ​reporting this issue.

• Corrected bug in get_grid.F when the UV_DRAG_GRID and PIO_LIB library C-preprocessing options are activated. Many thanks to Pan Feng for ​bringing this issue to our attention.

• Corrected typo in equilibrium_tide.F. Many thanks to Pan Feng for ​reporting this problem.

• Updated nesting.F to ensure that the averaged zeta in the donor grid is not less than Dcrit when WET_DRY is activated. Introduced a REFINE_BOUNDARY C-preprocessing option to suppress updating u, v, ubar, and vbar in fine2coarse. The default is to REFINE_BOUNDARY off. Many thanks to John Warner for the update.

This update corrects minor issues in the following files:

• close_io.F: Ensure that the biology model header file is written into the bio_file global attribute in output NetCDF files. Many thanks to Aijun Zhang for bringing this problem to my attention.

• set_contact.F: Correct of the get_Vweights switch to accelerate nested computations. We need instead:

  !
  !  Set the switch to compute vertical interpolation weights. Currently,
  !  they are only needed in non-coincident composite grids.
  !
        IF (ANY(Lcoincident).or.ANY(Lcomposite)) THEN
          get_Vweights=.TRUE.
        ELSE
          get_Vweights=.FALSE.
        END IF
  

  Many thanks to Andy Moore for reporting this issue.