Custom Query (964 matches)

The definition of the free-surface had an additional variable argument to include the water_points attribute in the data assimilation initial/restart file (DAINAME):

!
! Define free-surface.
!
  Vinfo( 1)=Vname(1,idFsur)
  Vinfo( 2)=Vname(2,idFsur)
  Vinfo( 3)=Vname(3,idFsur)
  Vinfo(14)=Vname(4,idFsur)
  Vinfo(16)=Vname(1,idtime)
  Vinfo(20)='mask_rho'
  Vinfo(22)='coordinates'
  Aval(5)=REAL(Iinfo(1,idFsur,ng),r8)
  status=def_var(ng, iNLM, DAI(ng)%ncid, DAI(ng)%Vid(idFsur), &
# ifdef WET_DRY
  & NF_FRST, nvd3, t2dgrd, Aval, Vinfo, ncname, &
  & SetFillVal = .FALSE.)
# else
  & NF_FRST, nvd3, t2dgrd, Aval, Vinfo, ncname)

# endif
  IF (exit_flag.ne.NoError) RETURN

The Vinfo(20)='mask_rho' attibute is wrong for this file.

Also, the NetCDF ID (ncid) for all I/O structures is initialized to closed state in mod_iounits.F:

!
!-----------------------------------------------------------------------
! Initialize I/O NetCDF files ID to close state.
!-----------------------------------------------------------------------
!
  DO ng=1,Ngrids
  ADM(ng)%ncid=-1
  ADS(ng)%ncid=-1
  AVG(ng)%ncid=-1
  BLK(ng)%ncid=-1
  BRY(ng)%ncid=-1
  CLM(ng)%ncid=-1
  DAI(ng)%ncid=-1
  DAV(ng)%ncid=-1
  DIA(ng)%ncid=-1
  ERR(ng)%ncid=-1
  FLT(ng)%ncid=-1
  FWD(ng)%ncid=-1
  GRD(ng)%ncid=-1
  GST(ng)%ncid=-1
  HIS(ng)%ncid=-1
  HSS(ng)%ncid=-1
  IAD(ng)%ncid=-1
  INI(ng)%ncid=-1
  IRP(ng)%ncid=-1
  ITL(ng)%ncid=-1
  LCZ(ng)%ncid=-1
  LZE(ng)%ncid=-1
  NUD(ng)%ncid=-1
  OBS(ng)%ncid=-1
  QCK(ng)%ncid=-1
  RST(ng)%ncid=-1
  SSF(ng)%ncid=-1
  STA(ng)%ncid=-1
  TLF(ng)%ncid=-1
  TLM(ng)%ncid=-1

  TIDE(ng)%ncid=-1

  NRM(1:4,ng)%ncid=-1
  STD(1:4,ng)%ncid=-1
  END DO

• The routine def_mod.F, which creates output NetCDF file MODNAME used in data assimilation or verification to write model values at observations locations and other data assimilation variables, was upgraded to check if the input observations have the global attributes state_variables and obs_provenance. Some users are not adding these important metadata information to input observation NetCDF.

• Added new subroutine netcdf_get_satt to module mod_netcdf.F. It is used to read global or variable NetCDF string attribute(s).

• Updated routine read_asspar.F to provide more information when the VERIFICATION option is activated.

The variable idefQCK in mod_ncparam.F was unallocated. This was giving a segmentation error in output.F line 147:

forrtl: severe (408): fort: (2): Subscript #1 of the array IDEFQCK has value 1 which is greater than the upper bound of -1

Image              PC                Routine            Line        Source
oceanG             000000010E8687B4  _output_                  147  output.f90
oceanG             000000010E7DE034  _main3d_                  215  main3d.f90
oceanG             000000010D8670FD  _ocean_control_mo         178  ocean_control.f90
oceanG             000000010D865261  _MAIN__                    86  master.f90
oceanG             000000010D864D16  Unknown               Unknown  Unknown

when input parameter NDEFQCK had a nonzero value during the creation of the QUICKSAVE output NetCDF file.

Also, fixed the inquiring of existing QUICKSAVE file during restart in def_quick.F. Need to add surface variables for momentum and tracers so they can be appended to an existing QUICKSAVE file. The surface tracer variables indices need to be stored in QCK(ng)%Vid(idsurT(itrc)) instead of QCK(ng)%Tid(itrc).

Many thanks to users at NOAA for bringing this to my attention.