Custom Query (986 matches)

Notice that the Point Sources and Sinks (like river runoff, etc) in ROMS are implemented in two ways:

(1) As a transport flux in the horizontal advection equations. This is usually the standard way and it is controlled by input logical switch LuvSrc in ocean.in for the specified nested grid.

(2) As a vertical mass flux divergence in the omega-velocity equation. This is alternative approach is controlled by input logical switch LwSrc in ocean.in for the specified nested grid.

From now on, we are making sure that only one of the above methods are allowed for a particular nested grid, ng. Otherwise, the Point Sources/Sinks will be applied twice.

In this update, the logic to use LuvSrc and LwSrc is cleaned to use either of the above methodologies. The method (2) is also added to the tracer predictor step in pre_step3d.F in the same way as the corrector step in step3d_t.F.

We need add deallocation of communication array Arec in routine mp_scatter_state of distribute.F:

!
!  Deallocate receive buffer.
!
      IF (allocated(Arecv).and.(MyRank.eq.MyMaster)) THEN
        deallocate (Arecv)
      END IF

The mp_scatter_state is not currently used in ROMS. So this memory leak doesn't affect the ROMS MPI communications.

Also corrected an information type in def_rst.F.

Corrected the output variable long-name for output inert tracers. What ROMS computes in the age concentration and not the concentration mean age.

So we need to have:

    double dye_01(ocean_time, s_rho, eta_rho, xi_rho) ;
                    dye_01:long_name = "dye concentration, type 01" ;
                    dye_01:units = "kilogram meter-3" ;
                    dye_01:time = "ocean_time" ;
                    dye_01:coordinates = "x_rho y_rho s_rho ocean_time" ;
    double dye_01_age(ocean_time, s_rho, eta_rho, xi_rho) ;
                    dye_01_age:long_name = "age concentration, type 01" ;
                    dye_01_age:units = "second kilogram meter-3" ;
                    dye_01_age:time = "ocean_time" ;
                    dye_01_age:coordinates = "x_rho y_rho s_rho ocean_time" ;

instead of:

       double dye_01_age(ocean_time, s_rho, eta_rho, xi_rho) ;
                dye_01_age:long_name = "dye concentration mean age, type 01" ;
                dye_01_age:units = "second" ;
                dye_01_age:time = "ocean_time" ;
                dye_01_age:coordinates = "x_rho y_rho s_rho ocean_time" ;

So we corrected the output metadata for long_name. To compute the concentration mean age, we need to have dye_01_age/dye_01 during post-processing.

Many thanks to John Wilkin for bringing this to my attention.

I also corrected CPP typo in mod_stepping.F. We need to have ADJUST_BOUNDARY instead.