Custom Query (986 matches)

In lmd_skpp.F and lmd_bkpp.F, there is a clamp applied to the boundary layer depth:

          hsbl(i,j)=MIN(hsbl(i,j),z_w(i,j,N(ng)))
          hsbl(i,j)=MAX(hsbl(i,j),z_w(i,j,0))

This happens before the Shapiro filter (LMD_SHAPIRO) is applied (if it is applied). It also needs to happen after the filter.

There is a sign error in get_3dfldr.F where it checks if data that has a cycle_length needs to be read. Lines 149-154 say the following:

        IF (Liocycle) THEN
          Trec=MOD(Trec,Nrec)-1
          IF (Trec.le.0) Trec=Nrec-Trec
        ELSE
          Trec=Trec-1
        END IF

The issue is with Trec=Nrec-Trec , which makes Trec greater than nrec instead of cycling the integer. It should actually be Trec=Nrec+Trec to be consistent with get_2dfldr.F'

Attached is a lightly modified version of fennel.h with the following improvements, mostly minor, but a significant bug fix:

1. Added implicit none.

2. Simplified declaration of u10squ.

3. Simplified treatment of N & C remineralization fluxes. (I made this change to allow the addition of a third detritus class in my branch of ROMS, but it's worth propagating back into the trunk.)

4. The bug fix: defined a factor fiter = 1/BioIter(ng), applied in calculating diagnostic rate variables. Without this factor all such rate variables are overestimated when BioIter(ng) exceeds 1. I have checked this one out pretty thoroughly!