Custom Query (964 matches)

There is a sign error in get_3dfldr.F where it checks if data that has a cycle_length needs to be read. Lines 149-154 say the following:

        IF (Liocycle) THEN
          Trec=MOD(Trec,Nrec)-1
          IF (Trec.le.0) Trec=Nrec-Trec
        ELSE
          Trec=Trec-1
        END IF

The issue is with Trec=Nrec-Trec , which makes Trec greater than nrec instead of cycling the integer. It should actually be Trec=Nrec+Trec to be consistent with get_2dfldr.F'

Attached is a lightly modified version of fennel.h with the following improvements, mostly minor, but a significant bug fix:

1. Added implicit none.

2. Simplified declaration of u10squ.

3. Simplified treatment of N & C remineralization fluxes. (I made this change to allow the addition of a third detritus class in my branch of ROMS, but it's worth propagating back into the trunk.)

4. The bug fix: defined a factor fiter = 1/BioIter(ng), applied in calculating diagnostic rate variables. Without this factor all such rate variables are overestimated when BioIter(ng) exceeds 1. I have checked this one out pretty thoroughly!

I thought we had taken care of this, but it is not corrected in the main repository. This is only for the error checking, and will not change results since this is the diagnostic quantities for debugging mass and volume conservation. But can you update this for nesting.F:

• Line 754 needs to change from

                EastSum=WestSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)
to
                EastSum=EastSum+BRY_CONTACT(ieast,cr)%Mflux(Jbf)

• Line 767 needs to change from

                MFratio=REFINED(cr)%DU_avg2(1,m,tnew)/WestSum
to
                MFratio=REFINED(cr)%DU_avg2(1,m,tnew)/EastSum

• Line 817 needs to change from

               IF (EastSum.ne.0) THEN
to
               IF (SouthSum.ne.0) THEN

• Line 859 needs to change from

               m=BRY_CONTACT(isouth,cr)%C2Bindex(Ibf)    ! pick last one
to
               m=BRY_CONTACT(inorth,cr)%C2Bindex(Ibf)    ! pick last one

• Line 869-870 need to change from

              IF (EastSum.ne.0) THEN
                MFratio=REFINED(cr)%DV_avg2(1,m,tnew)/SouthSum
to
              IF (NorthSum.ne.0) THEN
                MFratio=REFINED(cr)%DV_avg2(1,m,tnew)/NorthSum