Custom Query (964 matches)

• Corrected a bug in set_contact.F when using WET_DRY. The variables Rcontact(cr) % Lweight, Ucontact(cr) % Lweight, Vcontact(cr) % Lweight needed to be initialized to their respective unmasked values (Lweight), even if WET_DRY is activated. The horizontal interpolation weights are rescaled in mask_hweights for the wet/dry cells. However, the horizontal weights need to be initialized in the permanent wet cells, which were not when WET_DRY is activated. Similar initialization is needed for the quadratic interpolation weights: Rcontact(cr) % Qweight, Ucontact(cr) % Qweight, Vcontact(cr) % Qweight. Many thanks to John Warner for bringing this to my attention.

• Corrected spelling of FORWARD_MIXING in mod_mixing.F when initializing mixing coefficients AkvG and AktG:

  #if defined FORWARD_READ && defined FORWARD_MIXING && defined SOLVE3D && \
      (defined TANGENT || defined TL_IOMS || defined ADJOINT)
       ...
  #end
  

  Many thanks to Gordon Zhang for ​reporting this typo.

There are a couple of errors in test/lake_jersey/Forward/ocean_lake_jersey.in: the paths of the varinfo.dat and grid and initial conditions files are incorrect.

A corrected version is attached.

In lmd_skpp.F and lmd_bkpp.F, there is a clamp applied to the boundary layer depth:

          hsbl(i,j)=MIN(hsbl(i,j),z_w(i,j,N(ng)))
          hsbl(i,j)=MAX(hsbl(i,j),z_w(i,j,0))

This happens before the Shapiro filter (LMD_SHAPIRO) is applied (if it is applied). It also needs to happen after the filter.