Custom Query (964 matches)

Moved the computation of the tl_LBC logical switches from read_phypar.F to inp_par.F to allow the processing of biology and sediment tracers. We need to delay the initialization of these switches because read_BioPar or read_SedPar needs to be called first. In inp_par.F we now have:

#if defined TANGENT || defined TL_IOMS
!
!  Set lateral boundary condition switches for the tangent linear
!  models (TLM and RPM) to the same values as the adjoint model.
!
        DO ivar=1,nLBCvar
          DO i=1,4
            tl_LBC(i,ivar,ng)%acquire  =ad_LBC(i,ivar,ng)%acquire
            tl_LBC(i,ivar,ng)%Chapman  =ad_LBC(i,ivar,ng)%Chapman
            tl_LBC(i,ivar,ng)%clamped  =ad_LBC(i,ivar,ng)%clamped
            tl_LBC(i,ivar,ng)%closed   =ad_LBC(i,ivar,ng)%closed
            tl_LBC(i,ivar,ng)%Flather  =ad_LBC(i,ivar,ng)%Flather
            tl_LBC(i,ivar,ng)%gradient =ad_LBC(i,ivar,ng)%gradient
            tl_LBC(i,ivar,ng)%nested   =ad_LBC(i,ivar,ng)%nested
            tl_LBC(i,ivar,ng)%nudging  =ad_LBC(i,ivar,ng)%nudging
            tl_LBC(i,ivar,ng)%periodic =ad_LBC(i,ivar,ng)%periodic
            tl_LBC(i,ivar,ng)%radiation=ad_LBC(i,ivar,ng)%radiation
            tl_LBC(i,ivar,ng)%reduced  =ad_LBC(i,ivar,ng)%reduced
          END DO
        END DO
#endif

Many thanks to Ha Joon Song for ​reporting this bug.

I also updated the makefile configuration file Darwin-ifort.mk to avoid warning errors from newer versions of the ifort compiler:

We need to have:

           FFLAGS := -heap-arrays -fp-model source

instead of

           FFLAGS := -heap-arrays -fp-model precise

for Fortran compiling. The precise argument is redundant.

The climatology tracer (active and passive) metadata is now computed internally in mod_ncparam.F:

      DO i=1,MT
        varid=varid+1
        IF (varid.gt.MV) THEN
          WRITE (stdout,60) MV, varid
          STOP
        END IF
        idTclm(i)=varid
        DO ng=1,Ngrids
          Fscale(varid,ng)=1.0_r8
          Iinfo(1,varid,ng)=r3dvar
        END DO
        WRITE (Vname(1,varid),'(a)')                                    &
     &        TRIM(ADJUSTL(Vname(1,idTvar(i))))
        WRITE (Vname(2,varid),'(a,a)')                                  &
     &        TRIM(ADJUSTL(Vname(2,idTvar(i)))), ' climatology'
        WRITE (Vname(3,varid),'(a)')                                    &
     &        TRIM(ADJUSTL(Vname(3,idTvar(i))))
        WRITE (Vname(4,varid),'(a,a)')                                  &
     &        TRIM(Vname(1,varid)), ', scalar, series'
        WRITE (Vname(5,varid),'(a,a)')                                  &
     &        TRIM(ADJUSTL(Vname(1,idTvar(i)))), '_time'
      END DO

Notice that:

• NetCDF variable name, Vname(1,:), is the same as the basic ROMS state tracer metadata.

• Units, Vname(3,:), are the same as the basic ROMS state tracer data.

• Default time attribute, Vname(5,:), is the same as the variable name but with the _time suffix. For example, temp_time, salt_time, and so on. Recall that other time-variables names are allowed provided that the input NetCDF variable has the "time" attribute with the appropriate value.

• The following lines are removed from metadata file varinfo.dat because they are not longer needed:

  'temp'                                             ! Input
    'potential temperature climatology'
    'Celsius'                                        ! [Celsius]
    'temp, scalar, series'
    'temp_time'
    'idTclm(itemp)'
    'r3dvar'
    1.0d0
  
  'salt'                                             ! Input
    'salinity climatology'
    'nondimensional'                                 ! [PSU]
    'salt, scalar, series'
    'salt_time'
    'idTclm(isalt)'
    'r3dvar'
    1.0d0
  

I forgot to update the metadata when I updated the tracer climatology logic in ​src:ticket:569. Many thanks to Jiang-peng Liang for bringing this to my ​attention.

I corrected the format number in various ecosystem *_inp.h files when reporting the LtracerCLM switches. Thanks again to Jiang-peng Liang for reporting this ​typo.

A small bug was corrected in ad_npzd_Franks.h, ad_npzd_powell.h, and ad_npzd_iron.h when updating the global biological tracers:

We need to have:

              ad_cff=ad_cff+Hz(i,j,k)*ad_t(i,j,k,nnew,ibio)
instead of
              ad_cff=add_cff+Hz(i,j,k)*ad_t(i,j,k,nnew,ibio)

We need to use ad_cff and not add_cff. Many thanks to Ha Joon Song for reporting this ​typo.