Custom Query (986 matches)

There is a typo in sediment_var.h when assigning the river runoff indices for noncohesive sediment tracers. We need to have instead:

              CASE ('idRtrc(isand)')
                load=.FALSE.
                IF (NNS.gt.0) THEN
                  varid=varid-1
                  DO i=1,NNS
                    varid=varid+1
                    idRtrc(isand(i))=varid
                    DO ng=1,Ngrids
                      Fscale(varid,ng)=scale
                      Iinfo(1,varid,ng)=gtype
                    END DO
                    WRITE (Vname(1,varid),'(a,i2.2)')                   &
     &                    TRIM(ADJUSTL(Vinfo(1))), i
                    WRITE (Vname(2,varid),'(a,a,i2.2)')                 &
     &                    TRIM(ADJUSTL(Vinfo(2))), ', size class ', i
                    WRITE (Vname(3,varid),'(a)')                        &
     &                    TRIM(ADJUSTL(Vinfo(3)))
                    WRITE (Vname(4,varid),'(a,a)')                      &
     &                    TRIM(Vname(1,varid)), ', scalar, series'
                    WRITE (Vname(5,varid),'(a)')                        &
     &                    TRIM(ADJUSTL(Vinfo(5)))
                  END DO
                  varid=varid+1
                END IF

Many thanks to Xiang-Ming Zeng for ​reporting this problem.

Added grid, initial conditions, and forcing Netcdf files for the BIO_TOY test case. It includes initial conditions for BIO_FENNEL, ECOSIM, NEMURO, and all NPZD models (NPZD_FRANKS, NPZD_IRON, and NPZD_POWELL). All the NetCDF files are now under svn control and located in the Data/ROMS/Grid, Data/ROMS/Initial, and Data/ROMS/Forcing sub-directories, respectively.

• The grid is a 5x5 double periodic domain sampled from the North Esstern North Atlantic (NENA) application. The grid is:

  Data/ROMS/Grid/bio_toy_grd.nc
  

• There are several initial conditions files according to ecosystem model. The fields are horizontally uniform which render ROMS into 1D vertical model. These files are:

  Data/ROMS/Initial/bio_toy_ini_fennel.nc     BIO_FENNEL
  Data/ROMS/Initial/bio_toy_ini_ecosim.nc     ECOSIM
  Data/ROMS/Initial/bio_toy_ini_nemuro.nc     NEMURO
  Data/ROMS/Initial/bio_toy_ini_npzd.nc       any NPZD model
  

• The forcing data is from a typical year (days 0.5 to 364.5) ECMWF 40-year re-analysis. The time coordinate has the cycle_length attribute with a 365 value. Therefore, this application can be run for several year with a prepetual annual forcing cycle. This file is

  Data/ROMS/Forcing/bio_toy_frc.nc
  

The user may want to change a particular initial condition field to a desired value. It is very easy to copy any of these files to a new one and use any NetCDF program to change the field values.

• I also fixed few documentation typos. Many thanks to Kate Hedström and David Robertson for bringing this to my attention.

Many thanks to Cristina Schultz and John Wilkin for ​bringing this to my attention. I think that it is better to have these NetCDF files under svn control so we don't forget them in the future.

The horizontal diffusivity arrays diff2 and diff4 were not set correctly to its appropriate values in ini_hmixcoef.F because the C-preprocessing options were misspelled. We need to have TS_DIF2 or TS_DIF4 instead. This caused the diff2 or diff4 arrays to be zero in the horizontal diffusion for tracer (t3dmix*.h routines).

The routine ini_hmixcoef.F was introduced recently. Oops, it took me awhile to hunt this one. I was looking in the advection scheme instead. A very stupid typo! I waist a lot of time looking for this one.